fix: detect inline HTML comments in markdown-html-comments lint - #141
Open
Kubudak90 wants to merge 1 commit into
Open
fix: detect inline HTML comments in markdown-html-comments lint#141Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
The lint was only checking for NodeValue::HtmlBlock but not NodeValue::HtmlInline, meaning inline HTML comments like: text <!-- comment --> more text were not being detected and reported. This change adds support for inline HTML comments by also checking NodeValue::HtmlInline in addition to NodeValue::HtmlBlock. Fixes ethereum#119
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
Problem
The
markdown-html-commentslint was only checking forNodeValue::HtmlBlockbut notNodeValue::HtmlInline. This meant that inline HTML comments like:text <!-- inline comment --> more textwere not being detected and reported, while block-level HTML comments were.
Solution
Added support for inline HTML comments by also checking
NodeValue::HtmlInlinein addition toNodeValue::HtmlBlock.Changes
html_comments.rsto handle both HtmlBlock and HtmlInline node typesinline_html_comment_error: Tests that inline comments are detected as errorsinline_html_comment_warn: Tests that inline comments are detected as warnings when status is in warn_for listTesting
All 4 tests pass:
warn(existing)error(existing)inline_html_comment_error(new)inline_html_comment_warn(new)