Refactor dotenv loading to use explicit paths in CLI and API modules#412
Merged
Refactor dotenv loading to use explicit paths in CLI and API modules#412
Conversation
- improving environment variable management and preventing conflicts with other .env files.
xzrderek
approved these changes
Jan 14, 2026
| parameters: Any = None | ||
|
|
||
|
|
||
| from dotenv import load_dotenv |
There was a problem hiding this comment.
Environment loading removed instead of using explicit path
Medium Severity
The load_dotenv() call was removed entirely from mcp_multi_client.py instead of being replaced with an explicit path like in other files (cli.py, init.py). When MCPMultiClient is used directly (not through the CLI), environment variables from .env files will no longer be loaded. The class still validates that required environment variables exist in _validate_environment_variables(), so this change breaks standalone usage of the module and is inconsistent with the pattern used in other files in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Standardizes environment loading to avoid accidental parent
.envusage.eval_protocol/cli.py, replace implicitload_dotenv()with explicit paths to.env.devand.envusingdotenv_path, preservingoverride=True.quickstart/svg_agent/vercel_svg_server/api/init.py, switch toload_dotenv(dotenv_path=Path('.') / '.env')..envauto-loading fromeval_protocol/mcp/mcp_multi_client.py.tests/test_no_implicit_dotenv.pyto AST-scan repo code and fail CI if anyload_dotenv()call lacks an explicitdotenv_path.Written by Cursor Bugbot for commit 432a649. This will update automatically on new commits. Configure here.