Bump jsdom from 26.1.0 to 29.1.1#130
Conversation
1727ac9 to
7e45240
Compare
7e45240 to
2cd3cb8
Compare
Greptile SummaryThis PR upgrades
Confidence Score: 5/5Safe to merge — all changes are consistent dependency and runtime upgrades with a single targeted test fix for the new jsdom selector behavior. The jsdom and Node.js upgrades are applied consistently across package.json, lock file, and all CI workflows. The only test change is a two-line assertion reorder that correctly accommodates jsdom 29's new selector engine delegating No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["jsdom 26.1.0\n(cssstyle + @acemir/cssom\nnwsapi selector engine)"] -->|upgrade| B["jsdom 29.1.1\n(css-tree CSSOM\n@asamuzakjp/dom-selector)"]
B --> C["New transitive deps\nparse5@8, undici@7\ntough-cookie@6, css-tree@3"]
B --> D["querySelector('#id')\nnow delegates to getElementById"]
D --> E["Test assertion order\nswapped in help-tooltips.test.js\n(spy check before querySelector)"]
F["Node.js 22.21.1"] -->|upgrade| G["Node.js 24.16.0"]
G --> H[".nvmrc added\nengines: >=24.9.0"]
G --> I["All CI workflow jobs\nupdated"]
Reviews (5): Last reviewed commit: "Support jsdom 29 on Node 24" | Re-trigger Greptile |
| "jest-environment-jsdom": "30.3.0", | ||
| "jest-extended": "7.0.0", | ||
| "jsdom": "26.1.0", | ||
| "jsdom": "29.1.1", |
There was a problem hiding this comment.
Install-script change flagged by Dependabot
Dependabot's PR description explicitly warns: "This version modifies prepare script that runs during installation." The prepare lifecycle script executes automatically on pnpm install, so a change here runs arbitrary code on every developer machine and CI runner. It's worth inspecting the published jsdom 29.1.1 package contents (e.g. via npm pack jsdom@29.1.1 or https://www.npmjs.com/package/jsdom?activeTab=code) to confirm the script change is benign before merging.
a167095 to
21207b1
Compare
Bumps [jsdom](https://github.com/jsdom/jsdom) from 26.1.0 to 29.1.1. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v26.1.0...v29.1.1) --- updated-dependencies: - dependency-name: jsdom dependency-version: 29.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
21207b1 to
5c45d8d
Compare
Bumps jsdom from 26.1.0 to 29.1.1.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
9b9ea7e29.1.107efb78Optimize computed style comparison5f66329Fix background-origin/background-clip in background shorthandad8af77Fix border shorthand handling5a3e88e29.1.073db204Update dependencies and dev dependenciesa7168a5Support ratio CSS unit type15346e0Fix style cache invalidation2a1e2cd29.0.24097d66Resolve computed CSS values lazily in CSSStyleDeclarationMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for jsdom since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.