Skip to content

Bump jsdom from 26.1.0 to 29.1.1 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eviltester merged 2 commits into from
Jun 11, 2026
+300 −27
Merged

Bump jsdom from 26.1.0 to 29.1.1 #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c45d8d
Bump jsdom from 26.1.0 to 29.1.1
dependabot[bot] Jun 11, 2026
e4403ec
Support jsdom 29 on Node 24
eviltester Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:
with:
version: 11.1.1

- name: Use Node.js 22.21.1
- name: Use Node.js 24.16.0
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.21.1
node-version: 24.16.0
cache: pnpm

- name: Install dependencies
Expand Down Expand Up @@ -64,10 +64,10 @@ jobs:
with:
version: 11.1.1

- name: Use Node.js 22.21.1
- name: Use Node.js 24.16.0
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.21.1
node-version: 24.16.0
cache: pnpm

- name: Install dependencies
Expand Down Expand Up @@ -101,10 +101,10 @@ jobs:
with:
version: 11.1.1

- name: Use Node.js 22.21.1
- name: Use Node.js 24.16.0
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.21.1
node-version: 24.16.0
cache: pnpm

- name: Install dependencies
Expand All @@ -123,13 +123,13 @@ jobs:
- name: Upload coverage artifact
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: coverage-report-node-22.21.1
name: coverage-report-node-24.16.0
path: coverage/

- name: Upload HTML coverage report
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: coverage-html-report-node-22.21.1
name: coverage-html-report-node-24.16.0
path: coverage/lcov-report/

storybook:
Expand All @@ -147,10 +147,10 @@ jobs:
with:
version: 11.1.1

- name: Use Node.js 22.21.1
- name: Use Node.js 24.16.0
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.21.1
node-version: 24.16.0
cache: pnpm

- name: Install dependencies
Expand Down Expand Up @@ -192,10 +192,10 @@ jobs:
with:
version: 11.1.1

- name: Use Node.js 22.21.1
- name: Use Node.js 24.16.0
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.21.1
node-version: 24.16.0
cache: pnpm

- name: Install dependencies
Expand All @@ -222,10 +222,10 @@ jobs:
with:
version: 11.1.1

- name: Use Node.js 22.21.1
- name: Use Node.js 24.16.0
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.21.1
node-version: 24.16.0
cache: pnpm

- name: Install dependencies
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:

strategy:
matrix:
node-version: [22.21.1]
node-version: [24.16.0]

steps:
- name: Check out repository
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-testenv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
- name: Set up Pages
uses: actions/configure-pages@45bfe0192ca1faeb007ade9deae92b16b8254a0d

- name: Use Node.js 22.21.1
- name: Use Node.js 24.16.0
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
with:
node-version: 22.21.1
node-version: 24.16.0

- name: Set up pnpm
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
24.16.0
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"version": "1.0.0",
"private": true,
"packageManager": "pnpm@11.1.1",
"engines": {
"node": ">=24.9.0"
},
"description": "A simple Data Table Editor that generates Markdown, CSV or JSON. It can also be used to interchange data between the formats, supporting editing in the grid.",
"main": "apps/web/index.html",
"workspaces": [
Expand Down Expand Up @@ -125,7 +128,7 @@
"jest": "30.4.2",
"jest-environment-jsdom": "30.4.1",
"jest-extended": "7.0.0",
"jsdom": "26.1.0",
"jsdom": "29.1.1",

@greptile-apps greptile-apps Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 security Install-script change flagged by Dependabot

Dependabot's PR description explicitly warns: "This version modifies prepare script that runs during installation." The prepare lifecycle script executes automatically on pnpm install, so a change here runs arbitrary code on every developer machine and CI runner. It's worth inspecting the published jsdom 29.1.1 package contents (e.g. via npm pack jsdom@29.1.1 or https://www.npmjs.com/package/jsdom?activeTab=code) to confirm the script change is benign before merging.

"playwright": "1.60.0",
"prettier": "3.8.3",
"react": "18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/core-ui/src/tests/utils/help-tooltips.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ describe('help tooltips module', () => {
updateHelpHints();

expect(root.querySelector('[data-role="inline-help-items"]')).not.toBeNull();
expect(dom.window.document.querySelector('#inline-help-items')).toBeNull();
expect(getElementByIdSpy).not.toHaveBeenCalledWith('inline-help-items');
expect(dom.window.document.querySelector('#inline-help-items')).toBeNull();
});

test('option help icons get an option-specific accessible label', () => {
Expand Down
Loading
Loading