Use http opts configured per http client for pod identity

[Szetty]

ExAws.PodIdentity is not working if Req (ExAws.Request.Req) is configured as http_client:

iex(1)> ExAws.PodIdentity.security_credentials(%{http_client: ExAws.Request.Req})
** (ArgumentError) unknown option :recv_timeout. Did you mean :receive_timeout?
    (req 0.5.15) lib/req/request.ex:1184: Req.Request.validate_options/2
    (req 0.5.15) lib/req.ex:549: Req.merge/2
    (req 0.5.15) lib/req.ex:1093: Req.request/2
    (ex_aws 2.6.0) lib/ex_aws/request/req.ex:24: ExAws.Request.Req.request/5
    (ex_aws 2.6.0) lib/ex_aws/pod_identity.ex:64: ExAws.PodIdentity.fetch_credentials/2
    (ex_aws 2.6.0) lib/ex_aws/pod_identity.ex:20: ExAws.PodIdentity.security_credentials/1

[bernardd]

Thanks @Szetty. Would this change not preclude you from being able to override the HTTP ops for pod_identity operations, though?

[Szetty]

Thanks @Szetty. Would this change not preclude you from being able to override the HTTP ops for pod_identity operations, though?

You would be able to override the HTTP opts as you would normally do for ex_aws, but you could not have different opts for pod identity calls than the common opts. Do you think this is necessary ?

[Szetty]

@bernardd any more thoughts ?

[bernardd]

Sorry for taking a while to get back to this one. My main concern is that anyone who currently has specific options configured for pod_identity calls will lose those. In other words, the change breaks behavioural compatibility with previous versions.

[Szetty]

Sorry for taking a while to get back to this one. My main concern is that anyone who currently has specific options configured for pod_identity calls will lose those. In other words, the change breaks behavioural compatibility with previous versions.

I understand, so what do you propose ? just removing recv_timeout from defaults ?