MBTI-PDF-SNAPSHOT-PRINT-LAYOUT-POLISH-10: add snapshot PDF render version#2577
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 506b5aeedc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return implode('-', [ | ||
| $baseHash, | ||
| self::MBTI_RESULT_PAGE_SNAPSHOT_SURFACE_VERSION, | ||
| self::MBTI_RESULT_PAGE_SNAPSHOT_RENDER_VERSION, |
There was a problem hiding this comment.
Keep PDF artifact keys under the catalog limit
When the artifact-slot dual-write rollout is enabled and an attempt has a normal 64-character content manifest hash but no report_snapshots row to supply a shorter hash, adding this render version makes the value passed as manifest_hash 157 characters (64 + surface + render + engine + locale + entitlement + variant). That exceeds report_artifact_versions.manifest_hash (string(..., 128)), so the sidecar insert fails under the app's strict MySQL config and the surrounding recordReportPdfSidecars() catch also skips the unified-access pdf_state=ready refresh for newly generated PDFs.
Useful? React with 👍 / 👎.
Summary
Why
PR-G changes only the rendered print layout in fap-web. Existing artifact keys include the snapshot surface and engine but not the print CSS/layout version, so a layout-only frontend fix could keep serving an old v4 PDF artifact. This PR adds minimal cache isolation without clearing production cache or bumping the surface.
Validation
Deferred
Companion fap-web PR will carry the print layout polish and PR-train metadata.