Add FDC3 v3 Sail demo state#432
Open
DovOps wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for lucky-concha-f3599f canceled.
|
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the state 014 FDC3 v3 + Sail demo path for TraderX, based on
@finos/fdc3@3.0.0-alpha.2and the Sail v3 beta line.This updates the state 014 specs, generation flow, runtime scripts, and smoke tests so TraderX can run as a Sail-hosted FDC3 v3 demo with:
/fdc3/appd/v2/apps@finos/fdc3-example-apps@3.0.0-alpha.2instead of TraderX-local Sail widget portsfdc3.instrument, andtraderx.accountcontext propagationThe local Sail override widget copies were removed from this state. The corresponding upstream Sail work is tracked separately so TraderX can converge on upstream Sail behavior instead of carrying patched Sail app/widget code inside the state pack.
Generator Cleanup Split
The state004 generator overlay cleanup is now split into #433. PR #432 may show the same
specs/004-containerized-compose-runtime/generation/patches/0001-state-overlay.patchfinal file until #433 lands, but reviewers should treat that generator hygiene change as owned by #433. Merge #433 first, then #432 can be rebased/updated normally with the demo-focused diff.Sail Dependency Note
State 014 is currently pinned to a temporary Sail fork branch for the demo:
https://github.com/DovOps/FDC3-Sail.gitcodex/state014-demo-runtime3c1d756eab2692325a0bfd28e665af393aeead29That branch is
sail-v3-betaplus the two Sail improvements this demo still needs:The prior TradingView widget PR is no longer a dependency. TradingView/Pricer now come from the canonical FDC3 toolbox examples, which aligns with finos/FDC3-Sail#327. Once #314 and #315 land upstream, state 014 should be able to move back to the upstream Sail branch/ref.
Related Tracking
specs/014-fdc3-intent-interoperability/system/upstream-followups.mdValidation
bash -n pipeline/render-state-014-fdc3-intent-interoperability.sh scripts/test-state-014-fdc3-intent-interoperability.sh scripts/start-state-014-fdc3-intent-interoperability-generated.sh scripts/status-state-014-fdc3-intent-interoperability-generated.shbash -n generated/code/target-generated/fdc3-intent-interoperability/sail/bootstrap/run-sail.sh generated/code/target-generated/fdc3-intent-interoperability/sail/bootstrap/apply-sail-demo-compat.sh generated/code/target-generated/fdc3-intent-interoperability/sail/bootstrap/merge-traderx-appd.shbash pipeline/render-state-014-fdc3-intent-interoperability.shtools/validate-frontmatter.shbash pipeline/speckit/validate-root-spec-kit-gates.shbash pipeline/speckit/validate-speckit-readiness.shbash pipeline/verify-spec-coverage.shSail combined branch validation:
npm run test:run -w @finos/sail-web -- workspace-storenpm run test:run -w @finos/sail-web -- app-directorynpm run typecheck -w @finos/sail-web