Remove stale state014 generator deletion hunks#433
Open
DovOps wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for lucky-concha-f3599f canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes stale state014 smoke-script deletion hunks from the state004 overlay patch.
Why this is necessary
While refreshing state014 for the FDC3 v3 / Sail demo, regeneration exposed that
specs/004-containerized-compose-runtime/generation/patches/0001-state-overlay.patchstill contained delete-file hunks for the state014 smoke scripts. Those hunks are generator metadata, not runtime demo logic, and they can make generated state output fight the checked-in state014 scripts after the later state is present.This is split from the state014 demo branch so the demo PR can stay focused on Sail/FDC3 behavior, while this PR fixes the upstream generator input used by future state generation.
Relationship to #432
This PR owns the generator-overlay cleanup that was discovered while preparing #432. Merge this before #432 so the FDC3/Sail demo PR can stay focused on state014 runtime and spec behavior.
Validation
bash pipeline/speckit/validate-root-spec-kit-gates.shrgchecks confirmed no remainingdiff --git a/scripts/test-state-014ortest-state-014-fdc3-*references in the overlay patch