fix: upgrade path for the package #76
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the Homebrew upgrade path by updating the brew upgrade command to use the full tap path floatpane/matcha/matcha instead of just matcha. This ensures that the upgrade command correctly references the package from the custom tap.
Key Changes:
- Updated the
brew upgradecommand in the auto-updater to use the full tap path format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| upgradeCmd := exec.Command("brew", "upgrade", "matcha") | ||
| upgradeCmd := exec.Command("brew", "upgrade", "floatpane/matcha/matcha") |
There was a problem hiding this comment.
The upgrade command now uses the full tap path floatpane/matcha/matcha, but the version detection command at line 1194 still uses just matcha. For consistency and to ensure proper functionality, both commands should reference the package the same way. Consider updating line 1194 to also use floatpane/matcha/matcha, or verify that the short form matcha works correctly for the upgrade command once the tap is already added.
| upgradeCmd := exec.Command("brew", "upgrade", "floatpane/matcha/matcha") | |
| upgradeCmd := exec.Command("brew", "upgrade", "matcha") |
1 participant
No description provided.