Skip to content

fix: upgrade path for the package #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrinoff merged 1 commit into from
Jan 2, 2026
Merged

fix: upgrade path for the package #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ func runUpdateCLI() error {
// continue to attempt upgrade even if update failed
}

upgradeCmd := exec.Command("brew", "upgrade", "matcha")
upgradeCmd := exec.Command("brew", "upgrade", "floatpane/matcha/matcha")
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade command now uses the full tap path floatpane/matcha/matcha, but the version detection command at line 1194 still uses just matcha. For consistency and to ensure proper functionality, both commands should reference the package the same way. Consider updating line 1194 to also use floatpane/matcha/matcha, or verify that the short form matcha works correctly for the upgrade command once the tap is already added.

Suggested change
upgradeCmd := exec.Command("brew", "upgrade", "floatpane/matcha/matcha")
upgradeCmd := exec.Command("brew", "upgrade", "matcha")

Copilot uses AI. Check for mistakes.
upgradeCmd.Stdout = os.Stdout
upgradeCmd.Stderr = os.Stderr
if err := upgradeCmd.Run(); err == nil {
Expand Down
Loading