Honor EoTime timezone assignments - #53
Open
OskarEichler wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EoTime#zone= currently ignores its argument and resolves the existing zone instead. Use the supplied zone, reject an unresolvable zone before mutating the object, and retain existing cache invalidation.
Nil continues to preserve the current zone; :local resolves the local zone explicitly.
Reproduction
Before: ["UTC", 0, 0, 0.0]. After: ["Asia/Kolkata", 5, 30, 0.0].
Also checked TZInfo object assignment, :local, nil, preservation of the absolute instant and rejecting "Invalid/Timezone" without corrupting the previous valid zone.
Verification
The current master's unreleased day-delta change was not brought into the consumer branch. No live scheduler or production operations were used. Linux/Windows and other Ruby runtimes were not run locally.
Breaking changes and limitations
Valid assignments now take effect instead of silently doing nothing. Invalid zone assignments now raise ArgumentError immediately, leaving the previous zone intact; callers relying on silently ignored assignments will observe this correction. No other time conversion or DST policy changes. No overlapping open PR or assignment issue was found.