Skip to content

Honor EoTime timezone assignments #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Honor EoTime timezone assignments #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dc0836
Honor timezone assignments and invalidate cached local time
OskarEichler Aug 27, 2026
80aa2f2
Add regression test for et-orbi PR #53
OskarEichler Aug 28, 2026
9719338
Store plain-text regression test for et-orbi PR #53
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/et-orbi/time.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,11 @@ def seconds=(f)

def zone=(z)

tz = self.class.get_tzone(z || zone)
fail ArgumentError.new("Cannot determine timezone from #{z.inspect}") \
unless tz

@zone = self.class.get_tzone(zone || :current)
@zone = tz

touch

Expand Down
27 changes: 27 additions & 0 deletions test/eo_time_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,33 @@
end
end

group '#zone=' do

test 'assigns the requested timezone and invalidates the time cache' do

ot = EtOrbi::EoTime.new(0, 'UTC')
ot.hour

ot.zone = 'Asia/Kolkata'

assert ot.zone.name, 'Asia/Kolkata'
assert ot.hour, 5
assert ot.min, 30
assert ot.to_f, 0.0
end

test 'does not change the timezone when assignment fails' do

ot = EtOrbi::EoTime.new(0, 'UTC')

assert_error(
lambda { ot.zone = 'Invalid/Timezone' },
ArgumentError)

assert ot.zone.name, 'UTC'
end
end

group '.utc' do

[
Expand Down