Raise ArgumentError for unsupported EoTime comparison operands - #55
Open
OskarEichler wants to merge 3 commits into
Open
Raise ArgumentError for unsupported EoTime comparison operands#55OskarEichler wants to merge 3 commits into
OskarEichler wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instantiate the intended ArgumentError when an unsupported comparison operand lacks to_f. Calling ArgumentError as a method currently raises NoMethodError instead, hiding the intended diagnostic.
Reproduction
EtOrbi::EoTime.new(0, "UTC") < Object.newraises NoMethodError before, ArgumentError after.The focused check covers <, <=, >, >= and <=>. Valid numeric and Time comparisons remain unchanged.
Verification
The current master's unreleased day-delta change was not brought into the consumer branch. No live scheduler or production operations were used. Linux/Windows and other Ruby runtimes were not run locally.
Breaking changes and limitations
Intentional exception-class correction: unsupported operands now raise ArgumentError rather than the accidental NoMethodError. No accepted operand types or comparison arithmetic changed. No overlapping current fix was found.