Skip to content

Raise ArgumentError for unsupported EoTime comparison operands #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Raise ArgumentError for unsupported EoTime comparison operands #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6e637a
Raise ArgumentError for unsupported comparison operands
OskarEichler Aug 27, 2026
d5ef4f8
Add regression test for et-orbi PR #55
OskarEichler Aug 28, 2026
ab8a35c
Store plain-text regression test for et-orbi PR #55
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/et-orbi/time.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ def strfz(code)

def _to_f(o)

fail ArgumentError(
fail ArgumentError.new(
"Comparison of EoTime with #{o.inspect} failed"
) unless o.respond_to?(:to_f)

Expand Down
13 changes: 13 additions & 0 deletions test/eo_time_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,19 @@
assert t0.send(comparator, t1), asserted
end
end

test 'rejects unsupported comparison operands with ArgumentError' do

ot = EtOrbi::EoTime.new(0, 'UTC')
operand = Object.new

[ :<, :<=, :>, :>=, :<=> ].each do |comparator|

assert_error(
lambda { ot.send(comparator, operand) },
ArgumentError)
end
end
end
end