Require child success when matching all input - #13
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The all combinator currently checks only how much input the child consumed. A failed child with zero length is therefore accepted when the input is empty. Also require a successful child result.
Reproduction
Before: returns "". After: returns nil, as the grammar requires x.
Checked valid "x", input-offset rollback and an intentionally empty-string grammar, which still succeeds.
Verification
No production operations. Other Ruby/platform combinations were not run locally; no full supported-platform claim. Current open/closed issue/PR searches found no overlapping fix.
Breaking changes
Intentional correctness change: grammars that cannot match empty input no longer report success for it. Grammars that explicitly match empty input are unchanged. Error-diagnostic formatting is handled by a separate patch.