Conversation
Signed-off-by: zeryx <1892175+zeryx@users.noreply.github.com>
Signed-off-by: zeryx <1892175+zeryx@users.noreply.github.com>
Signed-off-by: zeryx <1892175+zeryx@users.noreply.github.com>
…se cookiecutter Signed-off-by: zeryx <1892175+zeryx@users.noreply.github.com>
…have the same name as their template name Signed-off-by: zeryx <1892175+zeryx@users.noreply.github.com>
8 tasks
eapolinario
reviewed
May 30, 2023
Collaborator
eapolinario
left a comment
eapolinario
left a comment
There was a problem hiding this comment.
We can't remove the existing templates as that's going to break all users of pyflyte init using previous versions of flytekit.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts all templates to utilize the new Imagespec system released in flytekit 1.6.0.
This removes Dockerfiles and docker_build.sh files, which simplifies the README.md.
This PR also removes the cookiecutter templating engine, reducing the complexity of the individual examples found in each example directory.
This PR is dependent on flyteorg/flytekit#1665