Adds jinja2 to dependnecies#2413
Merged
eapolinario merged 1 commit intoflyteorg:masterfrom May 15, 2024
Merged
Conversation
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
cosmicBboy
approved these changes
May 14, 2024
Contributor
cosmicBboy
left a comment
There was a problem hiding this comment.
I'm ok with this, will defer to @eapolinario or @wild-endeavor for second opinion
Contributor
|
the failing seems to be unrelated |
Contributor
Author
|
I'm planning to have a follow up PR to remove |
Collaborator
|
dbt test failures are unrelated. Tracked in flyteorg/flyte#5351. |
eapolinario
approved these changes
May 15, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 21, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Jun 15, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Jun 15, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Follow up to #2360
Why are the changes needed?
In #2360, we removed the cookiecutter dependency, which also removed
jinja2. We requirejinja2to construct Flyte Decks.What changes were proposed in this pull request?
This PR adds
jinja2as as a direct dependency.How was this patch tested?
I built a Flytekit image without jinja2 installed and got this error:
Once
jinja2is installed, the FlyteDeck button appears.For reference the code is here:
flytekit/flytekit/deck/deck.py
Lines 162 to 176 in cc3a7a9