Repository navigation
Conversation
|
Possible duplicate (possible confidence): #27 PR #27 also updates install-related references to the renamed forumlify/public repo, but it only changed README links (git clone, docker pull), while #32 adds a new download/install.sh installer and updates the install/update/status/cleanup flows. The outcome is related but not substantially identical. Related item: #27 This is an automated similarity suggestion. The item has not been closed automatically. |
|
Automated review has started. I am checking this pull request now. |
Bundle ReportBundle size has no change ✅ Affected Assets, Files, and Routes:view changes for bundle: forumlify-next-client-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Automated review completed for commit |
Superseded by the automated review for commit 52adf76.
There was a problem hiding this comment.
Automated review
Mode: normal
Comment
The PR is now scoped to the Docker update workflow: a small, readable scripts/update-docker.sh with Compose v2/v1 fallback, the registry re-point to ghcr.io/forumlify/public:next, and updated README instructions. The previously reviewed download/install.sh (including its corrupt pid-file bug) is no longer part of this diff, and I found no blocking defects in the remaining changes. One non-blocking operational gap worth addressing: --no-deps means the database container is never started by the updater, so the script can report success while the app fails to connect if Postgres is down.
Result for maintainers
Adds scripts/update-docker.sh (Compose v2/v1 detection, pull app image, then up -d --no-deps app so only the app container is recreated when the image changes), re-points the app image and clone URL to the renamed forumlify/public repository, and rewrites the Docker-update docs. download/install.sh is removed from the PR, so the earlier pid-file finding no longer applies. The only remaining observation is non-blocking: the updater never starts the db service, so a stopped database container leaves the app down while the script reports success.
Model decision: safe to merge
Applied review policy: allow
Final status: safe to merge
Required changes: 0
Review notes: 1
| "${compose[@]}" pull app | ||
|
|
||
| echo "Applying the latest image to the Forumlify app container..." | ||
| "${compose[@]}" up -d --no-deps app |
There was a problem hiding this comment.
Review note: Update can leave the app down when the database container is not already running
up -d --no-deps app never starts the db service, so if the Postgres container is not already up (e.g., stopped after a host reboot, or the user runs the update script on a freshly cloned stack without first starting it), the app container starts, cannot reach the database, and the script still prints success at the end. Consider dropping --no-deps (db is not recreated anyway since its config does not change) or explicitly verifying the database container is running before applying the update.
Superseded by the automated review for commit 52adf76.
|
@bot 这个pr主要做了什么 |
|
这个 PR 主要做了以下几件事: 1. 新增
2. 更新
3. 更新
简单来说:把 Docker 更新流程从手动操作封装成一个幂等脚本,核心收益是——只更新应用容器,数据库容器和数据卷不中断,避免更新时数据服务停摆;同时把镜像仓库地址迁移到了新的 |
|
/conflict |
|
Conflict resolution requested by @lezi-fun. forumlify bot is resolving the current head and will push only after the configured validation and a separate final confirmation pass succeed. |
|
The focused validation-repair pass exceeded its 5-minute limit. No commit was pushed. |
Summary
scripts/update-docker.shwith Docker Compose v2 and v1 supportappimage, then runup -d --no-deps appso Compose recreates the app only when the image changeddownload/install.shfrom this PRValidation
bash -n scripts/update-docker.shdocker compose config--force-recreategit diff --checkNotes