franka_hardware: Add missing rclcpp_action and rclcpp_components dependencies in package.xml#169
Open
traversaro wants to merge 2 commits into
Open
franka_hardware: Add missing rclcpp_action and rclcpp_components dependencies in package.xml#169traversaro wants to merge 2 commits into
traversaro wants to merge 2 commits into
Conversation
Author
|
Related PR: #96 . I did not opened new PRs, but just for reference these are the whole dependencies that were missing according to our analysis: If you are interested, we can open dedicated PR for each, or a PR with all the missing dependencies. |
Contributor
|
Hi @traversaro , yes, maybe a all-in-one PR would be nice... less PRs means less testing on our side xd (we are anyways 'a bit' behind for all of this testing...) Cheers, |
Author
Ok, I will prepare it! |
francando
pushed a commit
that referenced
this pull request
Mar 13, 2026
Merge in MOCTRL/franka_ros2 from PRCUN-5656/ros2-intergration-tests-humble to humble * commit '2ea66b16f6b57238973c6a1d055cf5300dfab0c1': test: adds integration tests for example controllers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rclcpp_actiondependency was added in the CMake in 4a001fc#diff-f4465f78e3e87470bb5d2b22df0aa00dcc3a48b8f63c24feac83b9ca1074a2f5, but the dependency was not added in the package.xml .Similarly, the
rclcpp_componentsdependency was added in eae138a#diff-f4465f78e3e87470bb5d2b22df0aa00dcc3a48b8f63c24feac83b9ca1074a2f5, but it was not added in package.xml .