feat: expose device-level autoconnect and managed controls - #547
Conversation
|
The failing |
cachebag
left a comment
There was a problem hiding this comment.
Thanks, just need to tighten up this integration test. Great work!
@ryux1 I appreciate the work on this and LLMs are more than okay to use; but I don't need you to laundry the feedback I give through an LLM. I would like to speak to you as a human, since it is presumed that you take responsibility for your work regardless of how it was generated. |
|
Understood. Thanks for being direct, and thanks for reviewing and merging it. |
Summary
Device.autoconnectalongside the existing managed-state snapshotset_device_autoconnectandset_device_managedmethods for any NetworkManager deviceset_device_autoconnect(false)deliberately leaves an active connection alone, matching NetworkManager's property semantics.set_device_manageduses the writable property rather than the newer 1.58-onlySetManagedmethod, preserving the crate's compatibility with older NetworkManager releases; its state is therefore temporary and resets when NetworkManager restarts.Closes #541.
Validation
cargo checkcargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test -p nmrs --lib --all-features(647 passed)cargo test --doc --all-features --workspace(134 passed, 16 ignored)cargo test --all-features --workspace(647 unit tests and 134 doc tests passed; 5 environmental integration tests ignored)git diff --checkThe Docker integration harness was not run locally because Docker is unavailable on this host. The updated ignored veth contract compiled as part of the workspace test and is ready for the repository's isolated CI environment.
AI assistance
I used OpenAI Codex to help inspect the existing API patterns, check the implementation, and draft parts of the code and documentation. I reviewed the complete diff and ran the validation listed above.