chore(docs): delete plans and superpower stuff - #5972
Conversation
PR Summary by QodoRemove plans/superpowers docs and ignore those directories
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
🤖 Review · |
Site previewPreview: https://f0100bfe-site.fullsend-ai.workers.dev Commit: |
Code Review by Qodo
1.
|
fde5bb2 to
491daed
Compare
|
🤖 Finished Review · ✅ Success · Started 10:13 AM UTC · Completed 10:28 AM UTC |
ReviewFindingsMedium
Previous runReviewFindingsHigh
Medium
Low
Labels: PR deletes documentation directories (docs/plans/, docs/superpowers/) and updates references across ADRs, code comments, and website config Next steps:
|
waynesun09
left a comment
There was a problem hiding this comment.
One more finding that doesn't have a diff-anchorable line (none of the files below are touched by this PR):
[MEDIUM] Companion implementation-plan docs deleted with no archive, while ADRs 0057, 0058, and 0067 still normatively delegate detail to them
None of these three ADRs are touched by this PR, but they still explicitly point readers at the plan docs being deleted here:
docs/ADRs/0057-repos-management.md:96-98— "Manifest schema, field resolution semantics, subcommand specifications, and implementation details are in the repos management plan..."docs/ADRs/0058-agent-registration.md:76-77— "See the implementation plan for phasing, schema details, CLI behavior, and migration mechanics."docs/ADRs/0067-gitlab-cron-polling-event-dispatch.md:298-300,563-565— "Detailed implementation guidance ... is in the companion document: Implementation plan: GitLab cron-polling."
Suggestion: for these three, either add a short amendment noting the companion plan was retired (with date/PR reference) and inline a short summary in place of the delegating prose — matching the treatment already given to 0036/0038/0044/0045/0064 — or move the docs to an archived, non-lint-checked location instead of hard-deleting content still cited as the ADR's source of truth.
Signed-off-by: Hector Martinez <hemartin@redhat.com>
491daed to
93563a0
Compare
|
🤖 Review · ❌ Terminated · Started 8:31 AM UTC · Ended 8:48 AM UTC Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Superseded by updated review
|
🤖 Finished Review · ✅ Success · Started 8:31 AM UTC · Completed 8:48 AM UTC Commit: |
|
🤖 Finished Retro · ✅ Success · Started 12:53 PM UTC · Completed 1:07 PM UTC Commit: |
Retro: PR #5972 — delete plans and superpower docsWorkflow: Human-authored PR by What went well
Coverage gapThe human reviewer (waynesun09's comment) ran Merged with known defectThe stale reference at Evidence for existing issues (no new proposals filed)
Proposals filed |
Summary
Remove plans from the docs. If I remember correctly we discussed this at some point but I'm not sure why they are still here. cc @ralphbean
Related Issue
No one for now, waiting on input.
Changes
docs/plans/docs/superpowers/.gitignoreTesting
make lintpasses (stage changes first, then run)Checklist
!for breaking changes)