chore(dispatch): provide FULLSEND_WORK_ITEM_URL in addition to GITHUB_ISSUE_URL - #6611
Conversation
9d06233 to
cd4b558
Compare
PR Summary by QodoExpose ISSUE_URL alongside the legacy GitHub issue URL
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
🤖 Finished Review · ✅ Success · Started 8:09 PM UTC · Completed 8:23 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.15 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo
1. Per-org agents miss variable
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
Risk Assessment: moderate (2/5) DetailsTiny additive change (11 lines) to a high-churn CI workflow file with 35 commits in 30d from 12 authors; the low intrinsic complexity and exact scope match to the linked issue keep the composite at moderate. Previous runRisk Assessment: moderate (2/5) DetailsTiny additive change (5 lines) to a high-churn CI workflow file with 35 commits in 30d from 16 authors; the low intrinsic complexity and exact scope match to the linked issue keep the composite at moderate. Previous run (2)Risk Assessment: moderate (2/5) DetailsSmall additive CI workflow change (5 lines, 1 file) with matched issue scope, offset by the file being a high-churn hotspot with many authors and frequent fix commits. |
ReviewFindingsMedium
Low
Previous runReviewFindingsMedium
Previous run (2)ReviewFindingsHigh
Medium
Low
Labels: PR modifies dispatch workflow infrastructure (.github/workflows/reusable-dispatch.yml), adding env var plumbing for forge-agnostic entity URLs Next steps:
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
component/dispatch
…UE_URL As part of the CEL overlays work, it is now possible for generic dispatch to run either in response to a jira event or a github event. This means we cannot assume that the issue url is a github issue. All of the default agents today depend on that GITHUB_ISSUE_URL var. We need to keep this as a backwards-compatible thing for a while. Add a new TRIGGER_ENTITY_URL that exposes the entity.url of the triggering normalized event for agents to use. Fixes #6609 Signed-off-by: Ralph Bean <rbean@redhat.com>
cd4b558 to
662eacc
Compare
|
🤖 Finished Review · ✅ Success · Started 8:27 PM UTC · Completed 8:41 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.30 |
Superseded by updated review
fullsend-ai-review
Bot
added
the
requires-manual-review
waynesun09
left a comment
waynesun09
left a comment
There was a problem hiding this comment.
Review-only pass at head 662eacc. Two inline findings: one HIGH (the review job's new variable has no pull_request fallback, so it is empty on PR-triggered runs) and one MEDIUM (the normative Jira-poll-adapter doc already assigns entity.url to a different env-var name and is not updated here).
…d fix review stage fallback Addresses review feedback on #6611: 1. Rename TRIGGER_ENTITY_URL to FULLSEND_WORK_ITEM_URL to match the normative spec in docs/normative/normalized-event/v1/jira-poll-adapter.md and ADR 0063. The FULLSEND_WORK_ITEM_* variables are the canonical forge-agnostic names for entity metadata. 2. Fix FULLSEND_WORK_ITEM_URL for the review stage to include a fallback to .pull_request.html_url, since review's primary trigger is pull_request_target which has no .issue field. Without this fallback, the variable was empty on every PR-triggered review run. 3. Update jira-poll-adapter.md to clarify that FULLSEND_WORK_ITEM_URL is set for both GitHub and Jira events, making it truly forge-agnostic. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
|
🤖 Review · ❌ Terminated · Started 6:27 PM UTC · Ended 6:45 PM UTC Commit: |
Site previewPreview: https://39d61534-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 6:27 PM UTC · Completed 6:45 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.04 |
ralphbean
changed the title
|
@rbean, sorry, I misunderstood. I think you should use |
|
🤖 Finished Retro · ✅ Success · Started 8:03 PM UTC · Completed 8:17 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.50 |
Retro: PR #6611 —
|
…WORK_ITEM_URL Rename the Jira forge env var from TRIGGER_ENTITY_URL to FULLSEND_WORK_ITEM_URL across all references: harness config (triage.yaml runner and sandbox env), the Jira env file (env/jira/triage.env), documentation (docs/triage.md), and the local testing guide (LOCAL.md). This aligns with the decision in fullsend-ai/fullsend#6611 to standardize on FULLSEND_WORK_ITEM_URL. Note: pre-commit could not fetch remote hook repos due to sandbox network restrictions. Hooks were run directly (YAML validation, trailing whitespace, end-of-file, private key detection, gitleaks) and all passed. Closes fullsend-ai#1053
4 participants
As part of the CEL overlays work, it is now possible for generic dispatch to run either in response to a jira event or a github event. This means we cannot assume that the issue url is a github issue.
All of the default agents today depend on that GITHUB_ISSUE_URL var. We need to keep this as a backwards-compatible thing for a while.
Add a new FULLSEND_WORK_ITEM_URL that exposes the entity.url of the triggering normalized event for agents to use.
For a moment, the proposed var here was TRIGGER_ENTITY_URL based off some old issue about it. @waynesun09 pointed out in review that we already have a normative spec doc merged that defines
FULLSEND_WORK_ITEM_URLas the correct var to use here - so, I've switched to that.Fixes #6609