Improve host_list performance #754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-5-1
force-pushed
the
host_list_perf
branch
from
d96be33 to
5bc9a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a crash when trying to access Hosts page on Patchman 4 installed with MySQL as MySQL was trying to write more than 10 GB of temporary tables to disk, filling up
/tmpand resulting in query crash because of the lack of free space.This patch is a courtesy of ChatGPT (with minor edits) but seems correct even from the results I get when running it on out Patchman instance. And performance seems decent (< 2 seconds load page with 1000+ hosts).