Skip to content

Improve host_list performance #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
David-5-1 wants to merge 1 commit into from
Closed

Improve host_list performance #754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 39 additions & 5 deletions hosts/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

from django.contrib import messages
from django.contrib.auth.decorators import login_required
from django.db.models import Count, Q
from django.db.models import Count, IntegerField, OuterRef, Q, Subquery
from django.shortcuts import get_object_or_404, redirect, render
from django.urls import reverse
from django_filters import rest_framework as filters
Expand Down Expand Up @@ -76,11 +76,45 @@ def _get_filtered_hosts(filter_params):

@login_required
def host_list(request):
# Pre-compute security updates, bug updates, errata and packages for speed
sec_updates_sq = Subquery(
Host.updates.through.objects.filter(
host_id=OuterRef("pk"), packageupdate__security=True
)
.values("host_id")
.annotate(c=Count("packageupdate_id", distinct=True))
.values("c"),
output_field=IntegerField(),
)
bug_updates_sq = Subquery(
Host.updates.through.objects.filter(
host_id=OuterRef("pk"), packageupdate__security=False
)
.values("host_id")
.annotate(c=Count("packageupdate_id", distinct=True))
.values("c"),
output_field=IntegerField(),
)
errata_sq = Subquery(
Host.errata.through.objects.filter(host_id=OuterRef("pk"))
.values("host_id")
.annotate(c=Count("erratum_id", distinct=True))
.values("c"),
output_field=IntegerField(),
)
packages_sq = Subquery(
Host.packages.through.objects.filter(host_id=OuterRef("pk"))
.values("host_id")
.annotate(c=Count("package_id", distinct=True))
.values("c"),
output_field=IntegerField(),
)

hosts = Host.objects.select_related().annotate(
sec_updates_count=Count('updates', filter=Q(updates__security=True), distinct=True),
bug_updates_count=Count('updates', filter=Q(updates__security=False), distinct=True),
errata_count=Count('errata', distinct=True),
packages_count=Count('packages', distinct=True),
sec_updates_count=sec_updates_sq,
bug_updates_count=bug_updates_sq,
errata_count=errata_sq,
packages_count=packages_sq,
)

if 'domain_id' in request.GET:
Expand Down