Closed
Conversation
Add a read-only `make tidy-check` target that runs `go mod tidy -diff` to verify go.mod and go.sum are tidy without modifying them, mirroring the validate-mod CI job in validate-spec.yml. Fixes #627
Deploying genealogix with
|
| Latest commit: |
7478e07
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5558832.genealogix.pages.dev |
| Branch Preview URL: | https://chore-tidy-check-target.genealogix.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a read-only make tidy-check target so contributors can locally verify go.mod/go.sum are tidy using go mod tidy -diff, matching the existing validate-mod CI job.
Changes:
- Add
tidy-checkMakefile target that runsgo mod tidy -diff(read-only verification). - Register
tidy-checkin.PHONYso it always runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isaacschepp
added a commit
that referenced
this pull request
Apr 2, 2026
Add a `make check` target that runs all locally-reproducible CI checks in a single command: tidy-check, lint, test, check-schemas, check-links, and validate-examples. Also adds the prerequisite targets `tidy-check` (go mod tidy -diff) and `validate-examples` (build CLI + validate all example archives) that were previously in separate PRs (#637, #636). Fixes #445 Closes #626 Closes #627
5 tasks
Collaborator
Author
|
Superseded by #641 which includes tidy-check as part of the make check target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a read-only
make tidy-checktarget that runsgo mod tidy -diffto verify go.mod and go.sum are tidy without modifying them, mirroring thevalidate-modCI job.Fixes #627
Test plan
make tidy-checkappears inmake helpoutputmake tidy-checkexits 0 on a clean repo (go.mod/go.sum are tidy)make tidy-checkexits 1 and prints a diff when go.mod is untidy