chore: add make check target that mirrors CI pipeline#641
Open
isaacschepp wants to merge 1 commit intomainfrom
Open
chore: add make check target that mirrors CI pipeline#641isaacschepp wants to merge 1 commit intomainfrom
isaacschepp wants to merge 1 commit intomainfrom
Conversation
Add a `make check` target that runs all locally-reproducible CI checks in a single command: tidy-check, lint, test, check-schemas, check-links, and validate-examples. Also adds the prerequisite targets `tidy-check` (go mod tidy -diff) and `validate-examples` (build CLI + validate all example archives) that were previously in separate PRs (#637, #636). Fixes #445 Closes #626 Closes #627
Deploying genealogix with
|
| Latest commit: |
abc07eb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0dbcc516.genealogix.pages.dev |
| Branch Preview URL: | https://chore-make-check-target.genealogix.pages.dev |
This was referenced Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new top-level make check entrypoint intended to run locally reproducible CI-style verification in one command, by composing existing and newly added Make targets.
Changes:
- Introduces
checkas an aggregate target that runs module tidiness, linting, tests, schema checks, link checks, and example validation. - Adds
tidy-check(go mod tidy -diff) to mirror CI’s module tidiness verification. - Adds
validate-examplesto build the CLI and runglx validateacross alldocs/examples/*/directories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
make checktarget that runs all locally-reproducible CI checks in one command, giving contributors confidence a PR will pass CI before pushing.check: tidy-check lint test check-schemas check-links validate-examplesAlso includes the prerequisite targets that were in separate PRs:
tidy-check—go mod tidy -diff(mirrors CIvalidate-modjob)validate-examples— builds CLI and validates all example archives (mirrors CIvalidate-examplesjob)Fixes #445
Closes #626
Closes #627
Supersedes PRs #636 and #637 (their changes are included here).
CI checks NOT in
make check(by design)make securitytarget (#438) — requires external toolsTest plan
make checkappears inmake helpmake tidy-checkrunsgo mod tidy -diffsuccessfullymake validate-examplesbuilds CLI and validates all 8 example directoriesmake checkruns all 6 sub-targets in order