Sign and notarize the bundled macOS client - #230
Open
bobvh wants to merge 1 commit into
Open
Conversation
Tag-triggered wheel builds now codesign and notarize the staged gen binary before it's packed into the macOS wheel, then re-verify the signature on the extracted binary inside the built wheel.
bobvh
force-pushed
the
pip-apple-signing
branch
from
August 7, 2026 16:29
88425a8 to
42f1d05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag-triggered wheel builds now codesign and notarize the staged
genbinary before it's packed into the macOS wheel, then re-verify the signature on the binary extracted from the built wheel.Sign bundled client (macOS)andNotarize bundled client (macOS)steps, gated ongithub.ref_type == 'tag'Verify bundled client signature (macOS)step unzips the built wheel and re-checks the signaturePROD_MACOS_*secrets already used byrelease.yml's macOS.pkgsigningStacked PR 5/5: pip-client → pip-abi3 → pip-targets → pip-publish-gating → pip-apple-signing