Skip to content

Sign and notarize the bundled macOS client #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobvh wants to merge 1 commit into
base: pip-targets
Choose a base branch
from
Open

Sign and notarize the bundled macOS client #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/workflows/python-wheels.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,61 @@ jobs:
- name: Stage bundled client (macOS)
if: runner.os == 'macOS'
run: make stage-python-client
- name: Sign bundled client (macOS)
if: runner.os == 'macOS' && github.ref_type == 'tag'
env:
MACOS_CERTIFICATE: ${{ secrets.PROD_MACOS_APP_CERTIFICATE }}
MACOS_CERTIFICATE_PWD: ${{ secrets.PROD_MACOS_APP_CERTIFICATE_PWD }}
MACOS_CERTIFICATE_NAME: ${{ secrets.PROD_MACOS_APP_CERTIFICATE_NAME }}
MACOS_CI_KEYCHAIN_PWD: ${{ secrets.PROD_MACOS_CI_KEYCHAIN_PWD }}
run: |
CERTIFICATE_PATH="$RUNNER_TEMP/gen-application-certificate.p12"
KEYCHAIN_PATH="$RUNNER_TEMP/gen-application-signing.keychain-db"
echo "$MACOS_CERTIFICATE" | base64 --decode > "$CERTIFICATE_PATH"
security create-keychain -p "$MACOS_CI_KEYCHAIN_PWD" "$KEYCHAIN_PATH"
security default-keychain -s "$KEYCHAIN_PATH"
security unlock-keychain -p "$MACOS_CI_KEYCHAIN_PWD" "$KEYCHAIN_PATH"
security import "$CERTIFICATE_PATH" \
-k "$KEYCHAIN_PATH" \
-P "$MACOS_CERTIFICATE_PWD" \
-T /usr/bin/codesign
security set-key-partition-list \
-S apple-tool:,apple:,codesign: \
-s \
-k "$MACOS_CI_KEYCHAIN_PWD" \
"$KEYCHAIN_PATH"
codesign \
--force \
--timestamp \
--options runtime \
--sign "$MACOS_CERTIFICATE_NAME" \
gen.gen.data/scripts/gen
codesign --verify --strict --verbose=2 gen.gen.data/scripts/gen
security delete-keychain "$KEYCHAIN_PATH"
- name: Notarize bundled client (macOS)
if: runner.os == 'macOS' && github.ref_type == 'tag'
env:
MACOS_CI_KEYCHAIN_PWD: ${{ secrets.PROD_MACOS_CI_KEYCHAIN_PWD }}
PROD_MACOS_NOTARIZATION_APPLE_ID: ${{ secrets.PROD_MACOS_NOTARIZATION_APPLE_ID }}
PROD_MACOS_NOTARIZATION_TEAM_ID: ${{ secrets.PROD_MACOS_NOTARIZATION_TEAM_ID }}
PROD_MACOS_NOTARIZATION_PWD: ${{ secrets.PROD_MACOS_NOTARIZATION_PWD }}
run: |
KEYCHAIN_PATH="$RUNNER_TEMP/gen-notarization.keychain-db"
NOTARIZATION_ARCHIVE="$RUNNER_TEMP/gen-client.zip"
ditto -c -k --keepParent gen.gen.data/scripts/gen "$NOTARIZATION_ARCHIVE"
security create-keychain -p "$MACOS_CI_KEYCHAIN_PWD" "$KEYCHAIN_PATH"
security default-keychain -s "$KEYCHAIN_PATH"
security unlock-keychain -p "$MACOS_CI_KEYCHAIN_PWD" "$KEYCHAIN_PATH"
security list-keychain -d user -s "$KEYCHAIN_PATH"
xcrun notarytool store-credentials "gen-notarytool-profile" \
--apple-id "$PROD_MACOS_NOTARIZATION_APPLE_ID" \
--team-id "$PROD_MACOS_NOTARIZATION_TEAM_ID" \
--password "$PROD_MACOS_NOTARIZATION_PWD" \
--keychain "$KEYCHAIN_PATH"
xcrun notarytool submit "$NOTARIZATION_ARCHIVE" \
--keychain-profile "gen-notarytool-profile" \
--wait
security delete-keychain "$KEYCHAIN_PATH"
- name: Stage bundled client (Windows)
if: runner.os == 'Windows'
shell: pwsh
Expand Down Expand Up @@ -83,6 +138,15 @@ jobs:
$ErrorActionPreference = 'Stop'
$wheel = Get-ChildItem "gen-python/target/wheels/*.whl"
python gen-python/scripts/verify_wheel.py "$($wheel.FullName)"
- name: Verify bundled client signature (macOS)
if: runner.os == 'macOS' && github.ref_type == 'tag'
run: |
CHECK_DIRECTORY="$RUNNER_TEMP/gen-wheel-check"
mkdir -p "$CHECK_DIRECTORY"
unzip -q gen-python/target/wheels/*.whl -d "$CHECK_DIRECTORY"
CLIENT_PATH=$(find "$CHECK_DIRECTORY" -type f -path "*/scripts/gen" -print -quit)
test -n "$CLIENT_PATH"
codesign --verify --strict --verbose=2 "$CLIENT_PATH"
- name: Smoke test wheel (macOS, Linux)
if: runner.os != 'Windows'
run: |
Expand Down
Loading