Skip to content

Remove reference to internals in error message for unused values #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 1 commit into from
Feb 7, 2026
+1 −2
Merged

Remove reference to internals in error message for unused values #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions include/rfl/parsing/ViewReader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ class ViewReader {
if (!already_assigned) {
std::stringstream stream;
stream << "Value named '" << _current_name_or_index
<< "' not used. Remove the rfl::NoExtraFields processor or add "
"rfl::ExtraFields to avoid this error message.";
<< "' not used.";
Comment on lines 144 to +145
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change simplifies the error message, but it also removes helpful context for the developer. While I understand the goal of not exposing library-specific names, the new message might leave developers wondering why an unused field is an error. A good compromise could be to add a hint explaining the reason, which would improve the developer experience without being too specific.

Suggested change
stream << "Value named '" << _current_name_or_index
<< "' not used. Remove the rfl::NoExtraFields processor or add "
"rfl::ExtraFields to avoid this error message.";
<< "' not used.";
stream << "Value named '" << _current_name_or_index
<< "' not used (extra fields are not allowed).";

_errors->emplace_back(Error(stream.str()));
}
}
Expand Down
Loading