feat: Add auth configurations.#90
Merged
david-hamilton-glean merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
steve-calvert-glean
approved these changes
Jan 21, 2026
Contributor
steve-calvert-glean
left a comment
steve-calvert-glean
left a comment
There was a problem hiding this comment.
Huge +1 to adding the redirect_uris to the configs.
| "configStructure": { | ||
| "serversPropertyName": "" | ||
| }, | ||
| "supportedAuth": ["token", "oauth-dcr"], |
Contributor
There was a problem hiding this comment.
2/5 (minor preference, non-blocking)
Just something that struck me; totally feel free to ignore.
Do you think we should use oauth:dcr with a more distinct delimiter? I don't mind much either way, but it feels a little cleaner?
Update schema + client docs to include known information about auth:
- does the client support token auth?
- does the client support DCR?
- if so, with what redirect URI patterns?
david-hamilton-glean
force-pushed
the
hjdivad/dcr/b
branch
from
94cc66e to
dcd70ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update schema + client docs to include known information about auth: