fix(evals): warn once when testInfo is missing#225
Open
steve-calvert-glean wants to merge 1 commit into
Open
Conversation
The 'testInfo not provided' warning fired on every runEvalDataset call without testInfo, spamming output when runVariantExperiment or scripted loops call it many times. Gate it behind a process-level flag so it warns once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nathaniel-furniss-glean
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runEvalDataset's "testInfo not provided" warning fired on every call withouttestInfo. When driving it programmatically (runVariantExperiment, scripted loops), that's the same message printed dozens of times, drowning real output.Gate it behind a process-level flag so it warns once.
Validation
format:check,typecheck,lint,docs:check,build,test(960 passing) all pass locally. No dedicated test: the flag is process-global (not resettable without exporting it), so an assertion would be order-dependent across the suite — not worth the brittleness for a one-line warn-dedup.🤖 Generated with Claude Code