Skip to content

fix(evals): warn once when testInfo is missing #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steve-calvert-glean wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(evals): warn once when testInfo is missing #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/evals/evalRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,10 @@ async function getGitHash(): Promise<string | undefined> {
return result.status === 0 ? result.stdout.trim() : undefined;
}

// ponytail: warn once per process, not per call — the message is identical and
// runVariantExperiment / scripted loops call this many times.
let warnedNoTestInfo = false;

export async function runEvalDataset(
options: EvalRunnerOptions,
context: EvalContext
Expand Down Expand Up @@ -1328,7 +1332,8 @@ export async function runEvalDataset(
contentType: 'application/json',
body: Buffer.from(JSON.stringify({ caseResults })),
});
} else if (caseResults.length > 0) {
} else if (caseResults.length > 0 && !warnedNoTestInfo) {
warnedNoTestInfo = true;
console.warn(
'[mcp-server-tester] runEvalDataset: testInfo not provided — results will not appear in the MCP reporter.\n' +
'To enable reporting, pass testInfo from the Playwright test function:\n' +
Expand Down
Loading