Cloudflare api v4#12
Open
thavelick wants to merge 9 commits into
Open
Conversation
Before, the cloudflare:cache:purge task would run once for each of the servers configured, across all roles. Really, this only needs to happen once per deploy, so now we call the CF API only once, from the local deployment machine
Ruby 1.9.3 was EOL'd Feburary 23 2015. It is also no longer supported by the latest version of capistrano itself, so support is being removed here. Updated the gemspec so that it's clear on RubyGems which version is required.
Since version 1 will be EOL'd soon
Cloudflare api v4
* Switched to httparty because I couldn't set the content-type header and send request params on a delete request with Net::HtTP * Fixed sucess and failure detection in rake task * Updated test to reflect actual response from cloudflare
Made cache purge actually work with v4 api
Check response properly for cache purge status
Contributor
|
hey @thavelick mind updating your branch with |
Contributor
|
Hey @thavelick just wanna check in on this branch, is this still something you'd like to merge in? |
|
Hi @joshrowley, Do you plan on adding CF API V4 support soon? :) |
Contributor
|
Hi @thavelick @pobrassard , I'm no longer a part of the @gofullstack GitHub organization and no longer have write access to this repository. I'm also no longer in a position to maintain this gem. I would advise forking, or maybe somebody from @gofullstack can weigh in here and merge or grant you maintainer access. |
Member
|
Hey guys:
I just invited you all as collaborators on the repo.
Cheers,
Josh Cramer
…On Wed, Sep 25, 2019 at 10:19 AM Josh Rowley ***@***.***> wrote:
Hi @thavelick <https://github.com/thavelick> @pobrassard
<https://github.com/pobrassard> , I'm no longer a part of the @gofullstack
<https://github.com/gofullstack> GitHub organization and no longer have
write access to this repository. I'm also no longer in a position to
maintain this gem. I would advise forking, or maybe somebody from
@gofullstack <https://github.com/gofullstack> can weigh in here and merge
or grant you maintainer access.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=AAAR7OEEBXRFB4WG72FZDBDQLOFQVA5CNFSM4CSLJBFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SPTLA#issuecomment-535099820>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAR7ODYQZRUUX4HVELHQB3QLOFQVANCNFSM4CSLJBFA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch upgrades the cloudflare API to v4.
Since the API has breaking changes, I've incremented the version of this module to 2.0. The new version takes a cloudflare zone identifier instead of a domain, so pushing out this fix as a minor version might break existing clients of the library, and I don't think we should do that without warning, but I'm open to discussion.
It also contains fixes for issues #7 and #1. Those have seperate pull requests that should be merged first.