Skip to content

Hide submissions with failed secret runs#490

Merged
msaroufim merged 1 commit into
mainfrom
qr-reward-hardening
Jun 15, 2026
Merged

Hide submissions with failed secret runs#490
msaroufim merged 1 commit into
mainfrom
qr-reward-hardening

Conversation

@msaroufim

Copy link
Copy Markdown
Member

Summary

  • Hide public scored runs when the same submission has a failed secret run for the same runner and mode.
  • Apply the filter to leaderboard rankings, personal leaderboard listings, submission counts, and authenticated user submission score summaries.
  • Add local DB regressions for public-pass plus secret-fail submissions.

Validation

  • uv run --extra dev pytest -q tests/test_leaderboard_db.py -k 'failed_secret_run or leaderboard_submission_ranked or leaderboard_submission_count'
  • uv run --extra dev pytest -q tests/test_leaderboard_db.py
  • uv run --extra dev python -m py_compile src/libkernelbot/leaderboard_db.py
  • git diff --check

Notes

  • This only changes visibility/filtering. It does not delete rows or mutate production data.
  • I did not run any production admin update/backfill command.

@github-actions

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/libkernelbot
  leaderboard_db.py
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@msaroufim msaroufim merged commit 941f5a8 into main Jun 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant