Fix ring local example failing getting TCP config overridden#694
Open
applejag wants to merge 1 commit into
Open
Fix ring local example failing getting TCP config overridden#694applejag wants to merge 1 commit into
applejag wants to merge 1 commit into
Conversation
|
@applejag I was getting the same issue after upgrading the lib version. Thanks for the PR, it resolve my issue. |
Contributor
|
Hi! 👋 We recently merged #947 which changed the CI configuration for unit tests. To get CI passing on this PR, please rebase on the latest Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
ring/example/localexample codeWhich issue(s) this PR fixes:
none
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]For context I was trying to use the ring example and was having issues with the following log messages:
Enabling debug logs showed some more juicy info:
The weird thing is that this only occurred on Go 1.23.0+. The example still specifies 1.22.0 where the bug was not present. To reproduce just change the Go version:
The errornous example set the timeout (TCPTransportConfig.AcquireWriterTimeout) to write a broadcast message to zero, which behaved differently between Go 1.22 and 1.23.
But now the example doesn't override the example anymore and works in both 1.22 and later.