Skip to content

Fix ring local example failing getting TCP config overridden #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
applejag wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ring local example failing getting TCP config overridden #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ring/example/local/local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,8 @@ func SimpleMemberlistKV(bindaddr string, bindport int, joinmembers []string) *me
config.Codecs = []codec.Codec{ring.GetCodec()}

// TCPTransport defines what addr and port this particular peer should listen on.
config.TCPTransport = memberlist.TCPTransportConfig{
BindPort: bindport,
BindAddrs: []string{bindaddr},
}
config.TCPTransport.BindPort = bindport
config.TCPTransport.BindAddrs = []string{bindaddr}

// joinmembers are the addresses of peers who are already in the memberlist group.
// Usually provided if this peer is trying to join an existing cluster.
Expand Down