fix(contract): real token transfer in deposit() - #74
Open
ZacLou wants to merge 1 commit into
Open
Conversation
- Import token::Client from soroban_sdk - Add token::Client::transfer() call in deposit() to move real tokens from caller to contract before updating internal balance - If transfer fails (insufficient balance, unauthorized), the entire transaction reverts — internal balance is never updated - Removes placeholder comment about allowing any asset Closes grantFoxin#55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Problem
The
depositfunction incontracts/src/lib.rsupdated the portfolio's internal balance record but never transferred actual tokens from the caller to the contract. After callingdeposit, the portfolio showed a balance that didn't match the contract's real token holdings — allowing users to get credit without depositing real assets.What this PR fixes
token::Clientfromsoroban_sdktoken_client.transfer()call indeposit()to move real tokens from the caller to the contract address before updating the internal balanceKey details
token::Client)require_auth()but before balance update — fail-fast on insufficient fundsenv.current_contract_address()Acceptance criteria
deposittransfers tokens from caller to contract via Soroban token interfacerequire_auth)