Skip to content

fix(contract): real token transfer in deposit() #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZacLou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(contract): real token transfer in deposit() #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions contracts/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#![no_std]
use soroban_sdk::{contract, contractimpl, Address, Env, Map};
use soroban_sdk::{contract, contractimpl, token, Address, Env, Map};

mod portfolio;
mod reflector;
Expand Down Expand Up @@ -93,13 +93,12 @@ impl PortfolioRebalancer {

portfolio.user.require_auth();

// Verify asset is in portfolio (optional based on requirements, but good practice)
if !portfolio.target_allocations.contains_key(asset.clone()) {
// For now, allow depositing any asset, as users might deposit first then rebalance
// or maybe we should restrict? The issue says "valid and invalid inputs".
// Let's assume valid input means positive amount and valid asset.
}

// Transfer real tokens from caller to contract via Soroban token interface.
// Must happen before balance update - if transfer fails, transaction reverts.
let contract_address = env.current_contract_address();
let token_client = token::Client::new(&env, &asset);
token_client.transfer(&portfolio.user, &contract_address, &amount);
let current_balance = portfolio.current_balances.get(asset.clone()).unwrap_or(0);
portfolio.current_balances.set(asset.clone(), current_balance + amount);

Expand Down