fix(Label): move key-value separator to left part of element#2580
Open
fix(Label): move key-value separator to left part of element#2580
Conversation
Contributor
|
Preview is ready. |
Contributor
|
🎭 Component Tests Report is ready. |
ukqfhf
reviewed
Feb 12, 2026
|
|
||
| &__separator { | ||
| margin: 0 4px; | ||
| margin: 0 4px 0 2px; |
There was a problem hiding this comment.
Would it be better to make these values token‑based?
Member
Author
There was a problem hiding this comment.
Could you specify which tokens you mean?
There was a problem hiding this comment.
--g-spacing-half for 2px and --g-spacing-1 or --g-spacing-base for 4px. At the moment, these values cannot be customized. Of course, it would be better if these values were relative like em, in this case, if the font size increases, then the distance from the separator should increase also.
There was a problem hiding this comment.
Even better to specify component specific tokens like --comp-label-separator-margin or something at the top element to enable deep customization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.