Skip to content

fix(Label): move key-value separator to left part of element #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goshander wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(Label): move key-value separator to left part of element #2580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33006db
fix(Label): move key-value separator to left part of element
goshander Feb 9, 2026
b5e75ea
Merge branch 'main' into fix-label-key-value
goshander Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/Label/Label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,17 @@ $transition-timing-function: ease-in-out;
overflow: hidden;
}

&__key {
opacity: 0.7;
}

&__value {
display: flex;
opacity: 0.7;
overflow: hidden;
}

&__separator {
margin: 0 4px;
margin: 0 4px 0 2px;
Copy link

@ukqfhf ukqfhf Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to make these values token‑based?

Copy link
Member Author

@goshander goshander Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify which tokens you mean?

Copy link

@ukqfhf ukqfhf Feb 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--g-spacing-half for 2px and --g-spacing-1 or --g-spacing-base for 4px. At the moment, these values cannot be customized. Of course, it would be better if these values were relative like em, in this case, if the font size increases, then the distance from the separator should increase also.

Copy link

@ukqfhf ukqfhf Feb 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better to specify component specific tokens like --comp-label-separator-margin or something at the top element to enable deep customization

}

&__main-button {
Expand Down
Loading