Skip to content

First try of possibility of non-encrypted server list#322

Open
wacki4 wants to merge 4 commits into
h3imdall:developmentfrom
wacki4:allow-no-encryption
Open

First try of possibility of non-encrypted server list#322
wacki4 wants to merge 4 commits into
h3imdall:developmentfrom
wacki4:allow-no-encryption

Conversation

@wacki4
Copy link
Copy Markdown
Contributor

@wacki4 wacki4 commented Aug 11, 2019

In addition to #321 could be really good thing to go on. Many persons also has encrypted home folder.

Default encryption is enabled, i'm thinking also of 'encrypt password' option for future use.

@cschindl
Copy link
Copy Markdown
Collaborator

cschindl commented Aug 12, 2019

Hi @wacki4,

a non-encrypted server list has already been requested several times (#224), because it has no real use for SSH agents and offers no additional security. However, as you've probably noticed, this can only be realized by major changes.

The following things would have to be adapted:

  • Migration of encrypted data to partially encrypted data (only passwords should be encrypted)
  • The master password would have to be requested once when establishing a connection to a server with encrypted password
  • If the master password has already been entered, the connection to other servers should be decrypted automatically.
  • When changing the master password, only the passwords of the servers would have to be re-encrypted and not the entire list

You may also think of other things that need to be adjusted.

@wacki4
Copy link
Copy Markdown
Contributor Author

wacki4 commented Aug 12, 2019

It answers almost fully my problems i had to think on ;)

Only have two one, on programical side:

  • When ftp-remote-edit is not initialized, how to get response of config change on encryption?
  • Is there any possibility to 'hide' fields over package config ? :) I think that showing full json would not be great, or do You think otherwise?

For first - we could ask for master password only on connection, and initialize plugin always on start. On second one - i didn't found nothing :)

Also... stupid question, but i was trying to find it and didn't... how to change password now in package ? :)

@cschindl
Copy link
Copy Markdown
Collaborator

When ftp-remote-edit is not initialized, how to get response of config change on encryption?

Changes to the configuration can always be requested as follows:

atom.config.onDidChange('ftp-remote-edit.config', () => { //some code });

Here, however, you always receive the encrypted data. Without entering the master password they are useless.

Is there any possibility to 'hide' fields over package config ? :) I think that showing full json would not be great, or do You think otherwise?

No, there's no way. However, I have already worked on moving the configuration to a separate file. But I still have to commit this.

How to change password now in package?

Change master password with "ftp-remote-edit:change-password"

Comment thread lib/ftp-remote-edit.js Outdated
atom.config.set('core.allowPendingPaneItems', true)
}

atom.config.onDidChange('ftp-remote-edit.encryption', ({ newValue, oldValue }) => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like here, fire only when the package was initalized first with toggle.

@wacki4
Copy link
Copy Markdown
Contributor Author

wacki4 commented Aug 13, 2019

Changes to the configuration can always be requested as follows:
It works only when ftp-remote-edit was initalized befored ;) Checked it. If not, changing this parameter does not fire (showed the fragment above).

@cschindl
Copy link
Copy Markdown
Collaborator

The function is called for the first time in the "init" function. Please simply move it to the "activate" function. This function is called when activating the plugin and registers all handlers.

@wacki4
Copy link
Copy Markdown
Contributor Author

wacki4 commented Aug 13, 2019

I will seat into this i think next week, shouldn't be so hard :)

@wacki4
Copy link
Copy Markdown
Contributor Author

wacki4 commented Aug 24, 2019

Done some changes, think that everything should be good after update and to work after it.

@cschindl cschindl changed the base branch from master to development August 30, 2019 15:56
@wacki4
Copy link
Copy Markdown
Contributor Author

wacki4 commented Aug 30, 2019

Fast correction over github merge panel, i think should work with current development branch ;)

@wacki4
Copy link
Copy Markdown
Contributor Author

wacki4 commented Dec 9, 2019

How is going merging it into developer? Need any help ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants