First try of possibility of non-encrypted server list

lib/config/config-schema.json

@@ -1,31 +1,47 @@
 {
+  "encryption": {
+    "title": "Mode of connection encryption",
+    "description": "Specifies the way in which server list is saved",
+    "type": "string",
+    "default": "encrypted",
+    "enum": [{
+        "value": "encrypted",
+        "description": "Encrypted"
+      },
+      {
+        "value": "plain",
+        "description": "Not encrypted"
+      }
+    ],
+    "order": 1
+  },
   "config": {
     "title": "Encrypted Connection",
     "description": "This are the encrypted connection information about your servers. Don't edit this!",
     "type": "string",
     "default": "",
-    "order": 1
+    "order": 2
   },
   "password": {
     "title": "Encrypted Password",
     "description": "This is the encrypted password. Don't edit this!",
     "type": "string",
     "default": "",
-    "order": 2
+    "order": 3
   },
   "allowedConsumers": {
     "title": "Whitelisted Consumers (encrypted)",
     "description": "You can clear this to disallow access to your server configuration for all third-party packages.",
     "type": "string",
     "default": "",
-    "order": 3
+    "order": 4
   },
   "disallowedConsumers": {
     "title": "Blacklisted Consumers (encrypted)",
     "description": "You can clear this to allow all third-party packages to request access to your server configuration.",
     "type": "string",
     "default": "",
-    "order": 4
+    "order": 5
   },
   "tree": {
     "type": "object",

lib/connectors/ftp.js

@@ -36,7 +36,7 @@ export default class Ftp extends EventEmitter {
       host: connection.host,
       port: (connection.port) ? connection.port : 21,
       user: connection.user,
-      password: connection.password,
+      password: connection.passwordDecrypted,
     };
 
     // TLS

lib/connectors/sftp.js

@@ -77,7 +77,7 @@ export default class Sftp extends EventEmitter {
       }
     }
     if (pw && connection.privateKey && !connection.passphrase) {
-      connection.passphrase = connection.password;
+      connection.passphrase = connection.passwordDecrypted;
     }
 
     connection.debug = (msg) => {
@@ -217,7 +217,7 @@ export default class Sftp extends EventEmitter {
       let input = FileSystem.createReadStream(localPath);
       input.pause();
 
-      // Declare events  
+      // Declare events
       const progressEvent = (progress) => {
         queueItem.changeProgress(progress.transferred);
         self.emit('data', progress.transferred);
@@ -320,7 +320,7 @@ export default class Sftp extends EventEmitter {
     let promise = new Promise((resolve, reject) => {
       let str = progress({ time: 100 });
 
-      // Declare events  
+      // Declare events
       const progressEvent = (progress) => {
         self.emit('debug', 'sftp:get:client.get:progress');
         queueItem.changeProgress(progress.transferred);

lib/ftp-remote-edit.js

@@ -107,6 +107,17 @@ class FtpRemoteEdit {
         }
       }
     });
+
+    atom.config.onDidChange('ftp-remote-edit.encryption', ({ newValue, oldValue }) => {
+      if (!Storage.hasPassword()) {
+        self.promptPassword().then(() => {
+          Storage.save();
+        });
+      } else {
+        Storage.save();
+      }
+    });
+
   }
 
   init() {
@@ -261,6 +272,10 @@ class FtpRemoteEdit {
     }
   }
 
+  isPasswordProvided() {
+    return atom.config.get('ftp-remote-edit.encryption') != 'encrypted' || Storage.hasPassword();
+  }
+
   getCurrentServerName() {
     const self = this;
 
@@ -291,7 +306,7 @@ class FtpRemoteEdit {
           return;
         }
 
-        if (!Storage.hasPassword()) {
+        if (!self.isPasswordProvided()) {
           reject('nopassword');
           return;
         }
@@ -313,39 +328,39 @@ class FtpRemoteEdit {
           detail: reasonForRequest + '\n-------------------------------\n' + caution,
           dismissable: true,
           buttons: [{
-            text: 'Always',
-            onDidClick: () => {
-              buttondismiss = true;
-              notif.dismiss();
-              addToWhiteList(Storage.getPassword(), reasonForRequest);
-              resolve(root.config);
-            }
-          },
-          {
-            text: 'Accept',
-            onDidClick: () => {
-              buttondismiss = true;
-              notif.dismiss();
-              resolve(root.config);
-            }
-          },
-          {
-            text: 'Decline',
-            onDidClick: () => {
-              buttondismiss = true;
-              notif.dismiss();
-              reject('userdeclined');
-            }
-          },
-          {
-            text: 'Never',
-            onDidClick: () => {
-              buttondismiss = true;
-              notif.dismiss();
-              addToBlackList(Storage.getPassword(), reasonForRequest);
-              reject('userdeclined');
-            }
-          },
+              text: 'Always',
+              onDidClick: () => {
+                buttondismiss = true;
+                notif.dismiss();
+                addToWhiteList(Storage.getPassword(), reasonForRequest);
+                resolve(root.config);
+              }
+            },
+            {
+              text: 'Accept',
+              onDidClick: () => {
+                buttondismiss = true;
+                notif.dismiss();
+                resolve(root.config);
+              }
+            },
+            {
+              text: 'Decline',
+              onDidClick: () => {
+                buttondismiss = true;
+                notif.dismiss();
+                reject('userdeclined');
+              }
+            },
+            {
+              text: 'Never',
+              onDidClick: () => {
+                buttondismiss = true;
+                notif.dismiss();
+                addToBlackList(Storage.getPassword(), reasonForRequest);
+                reject('userdeclined');
+              }
+            },
           ]
         });
 
@@ -378,6 +393,7 @@ class FtpRemoteEdit {
           resolve(true);
         } else {
           dialog.showError('Wrong password, try again!');
+          reject();
         }
       });
 
@@ -451,7 +467,7 @@ class FtpRemoteEdit {
 
     self.init();
 
-    if (!Storage.hasPassword()) {
+    if (!self.isPasswordProvided()) {
       if (!checkPasswordExists()) {
         self.changePassword('add').then((returnValue) => {
           if (returnValue) {
@@ -481,8 +497,7 @@ class FtpRemoteEdit {
     const self = this;
 
     self.init();
-
-    if (!Storage.hasPassword()) {
+    if (!self.isPasswordProvided()) {
       self.toggle();
     } else {
       self.getTreeViewInstance().toggleFocus();
@@ -499,8 +514,7 @@ class FtpRemoteEdit {
     const self = this;
 
     self.init();
-
-    if (!Storage.hasPassword()) {
+    if (!self.isPasswordProvided()) {
       self.toggle();
     } else {
       self.getTreeViewInstance().show();
@@ -522,7 +536,7 @@ class FtpRemoteEdit {
       root = selected.view().getRoot();
     };
 
-    if (!Storage.hasPassword()) {
+    if (!self.isPasswordProvided()) {
       self.promptPassword().then(() => {
         if (Storage.load()) {
           self.getConfigurationViewInstance().reload(root);
@@ -683,7 +697,7 @@ class FtpRemoteEdit {
       if (!FileSystem.existsSync(fullLocalPath)) {
         createLocalPath(fullLocalPath);
       }
-    } catch (err) { }
+    } catch (err) {}
 
     directory.getConnector().existsDirectory(fullRelativePath).then((result) => {
       showMessage('Directory ' + relativePath.trim() + ' already exists', 'error');
@@ -919,7 +933,7 @@ class FtpRemoteEdit {
         if (FileSystem.existsSync(fullLocalPath)) {
           FileSystem.unlinkSync(fullLocalPath);
         }
-      } catch (err) { }
+      } catch (err) {}
 
       file.parent.select();
       file.destroy();
@@ -1039,7 +1053,7 @@ class FtpRemoteEdit {
     const selected = self.getTreeViewInstance().list.find('.selected');
 
     if (selected.length === 0) return;
-    if (!Storage.hasPassword()) return;
+    if (!self.isPasswordProvided()) return;
 
     let element = selected.view();
     if (element.is('.file')) {
@@ -1056,7 +1070,7 @@ class FtpRemoteEdit {
     const selected = self.getTreeViewInstance().list.find('.selected');
 
     if (selected.length === 0) return;
-    if (!Storage.hasPassword()) return;
+    if (!self.isPasswordProvided()) return;
 
     let element = selected.view();
 
@@ -1072,7 +1086,7 @@ class FtpRemoteEdit {
     const selected = self.getTreeViewInstance().list.find('.selected');
 
     if (selected.length === 0) return;
-    if (!Storage.hasPassword()) return;
+    if (!self.isPasswordProvided()) return;
 
     let destObject = selected.view();
     if (destObject.is('.file')) {
@@ -1162,7 +1176,7 @@ class FtpRemoteEdit {
     const selected = self.getTreeViewInstance().list.find('.selected');
 
     if (selected.length === 0) return;
-    if (!Storage.hasPassword()) return;
+    if (!self.isPasswordProvided()) return;
 
     let destObject = selected.view();
     if (destObject.is('.file')) {
@@ -1237,7 +1251,7 @@ class FtpRemoteEdit {
     const selected = self.getTreeViewInstance().list.find('.selected');
 
     if (selected.length === 0) return;
-    if (!Storage.hasPassword()) return;
+    if (!self.isPasswordProvided()) return;
 
     let destObject = selected.view();
     if (destObject.is('.file')) {
@@ -1299,7 +1313,7 @@ class FtpRemoteEdit {
     const selected = self.getTreeViewInstance().list.find('.selected');
 
     if (selected.length === 0) return;
-    if (!Storage.hasPassword()) return;
+    if (!self.isPasswordProvided()) return;
 
     let defaultPath = self.currentDownloadPath;
     if (['project', 'desktop', 'downloads'].includes(defaultPath) === false && FileSystem.existsSync(defaultPath) === false) {
@@ -1962,7 +1976,7 @@ class FtpRemoteEdit {
 
           editor.saveObject.removeClass('open');
         });
-      } catch (err) { }
+      } catch (err) {}
     }).catch((err) => {
       showMessage(err.message, 'error');
     });