Make SVG export match GC ring controls - #42
Merged
Merged
Conversation
Deploying brigx with
|
| Latest commit: |
ea0bd39
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3cdd790c.brigx.pages.dev |
| Branch Preview URL: | https://codex-fix-svg-gc-ring-export.brigx.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The canvas preview received plot data filtered by the GC Content and GC Skew controls, but ExportPanel regenerated SVG from the original unfiltered plot data. PNG worked because it rasterised the already-filtered live canvas.
Reproduction
The new browser test failed before the implementation change because the downloaded SVG still contained
id="gc-content-ring"after GC Content was unticked.Validation
npm audit --omit=dev: zero vulnerabilitiesThe repository security script currently stops on advisory 1139427 in development-only
nanoid, pulled through Vite/PostCSS. This branch does not change dependencies.