Skip to content

Make SVG export match GC ring controls - #42

Merged
happykhan merged 1 commit into
masterfrom
codex/fix-svg-gc-ring-export
Sep 5, 2026
Merged

happykhan merged 1 commit into
masterfrom
codex/fix-svg-gc-ring-export

Conversation

@happykhan

Copy link
Copy Markdown
Owner

What changed

  • render SVG downloads from the same GC-filtered plot data shown on the canvas
  • keep the Data download backed by the complete analysis result
  • add a browser regression for disabling GC Content while leaving GC Skew enabled

Root cause

The canvas preview received plot data filtered by the GC Content and GC Skew controls, but ExportPanel regenerated SVG from the original unfiltered plot data. PNG worked because it rasterised the already-filtered live canvas.

Reproduction

The new browser test failed before the implementation change because the downloaded SVG still contained id="gc-content-ring" after GC Content was unticked.

Validation

  • lint, architecture and licence checks
  • 176 unit tests
  • production build
  • 25 production browser tests
  • Vite development-mode BLAST/WASM browser test
  • npm audit --omit=dev: zero vulnerabilities

The repository security script currently stops on advisory 1139427 in development-only nanoid, pulled through Vite/PostCSS. This branch does not change dependencies.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying brigx with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea0bd39
Status: ✅  Deploy successful!
Preview URL: https://3cdd790c.brigx.pages.dev
Branch Preview URL: https://codex-fix-svg-gc-ring-export.brigx.pages.dev

View logs

@happykhan
happykhan merged commit 0c9a2f4 into master Sep 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant