Skip to content

Centralize Canvas and SVG plot geometry - #43

Merged
happykhan merged 2 commits into
codex/fix-svg-gc-ring-exportfrom
codex/shared-plot-scene
Sep 5, 2026
Merged

happykhan merged 2 commits into
codex/fix-svg-gc-ring-exportfrom
codex/shared-plot-scene

Conversation

@happykhan

@happykhan happykhan commented Sep 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • introduce one renderer-independent plot scene for track visibility, radial layout, arc geometry, colours, tooltips, scale markers, and legends
  • reduce Canvas and SVG implementations to backend-specific painters consuming that scene
  • use the same presentation selector for the preview and exports
  • enforce the shared-scene boundary in the architecture check
  • add contract and SVG structure coverage for the shared scene

Why

Canvas preview and SVG export previously recalculated the plot independently. That allowed behaviour to drift whenever a control or renderer feature changed. This is stacked on #42 so the immediate GC export correction remains small and independently reviewable.

Verification

  • npm run lint
  • npm run quality:architecture
  • npm run quality:licenses
  • npm test (181 passed)
  • npm run build
  • npm run test:e2e (25 passed, with the session-preservation assertions from the next stacked commit included locally)
  • npm run test:e2e:dev (1 passed)

A direct npm audit currently reports pre-existing transitive nanoid advisory 1139427. This PR does not change dependencies. GitHub CI is configured only for PRs whose base is master, so this stacked PR receives the Cloudflare build check now and will receive the full workflow when retargeted after its prerequisite is merged.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Deploying brigx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74ef79c
Status: ✅  Deploy successful!
Preview URL: https://0d315e54.brigx.pages.dev
Branch Preview URL: https://codex-shared-plot-scene.brigx.pages.dev

View logs

@happykhan
happykhan merged commit bcbeabc into codex/fix-svg-gc-ring-export Sep 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant