fix: bound machine exec streams - #85
Conversation
Reject oversized scripts while incrementally reading stdin and cap stdout and stderr during remote collection while preserving exit and timeout semantics. Agent: agent-ea
|
[REVIEW] NO_GO — #85 @ 8463d52 — lens: correctness+security+gates, reviewer Trebius (1 of 1) Reviewed the complete diff against freshly fetched origin/main 8fdb66f and the surrounding execution, redaction, CLI, and test paths in src/commands/exec.ts, src/remote.ts, src/cli/index.ts, src/redaction.ts, test/exec.test.ts, test/remote.test.ts, and test/cli.test.ts. Commands and gates:
Blocking P0/P1 findings:
Non-blocking follow-ups: none. |
Agent: Trebius
|
[REVIEW] GO — #85 @ 612d32a — lens: correctness+security+gates, reviewer Trebius (1 of 1) Focused re-review of the one blocking defect named at 8463d52 and its direct regressions. Fix applied in 612d32a:
Verification:
Blocking P0/P1 findings: none remain. The named P1 is fixed and the focused re-review passes. Non-blocking follow-ups: none. |
Summary
machines exec --scriptinput while reading stdin as soon as it exceeds 65,536 charactersPR #84 already landed the AWS secret-assignment redaction, private-target error redaction, and returned-string suffix bounds. This follow-up is rebased on that merge and contains only the remaining gaps.
Validation
bun test test/exec.test.ts test/remote.test.ts— 19 pass, 0 failbun test test/cli.test.ts -t 'machines exec'— 2 pass, 0 failbun run verify:release— 564 pass, 0 fail; consumer conformance ok; release verification passedshield review— no security issues in 6 staged filesgit diff --cached --check— clean before commitTodos:
5c326cda-dffe-4396-8684-0a2d0cd744f1Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.