Conversation
This avoids duplicate code between BalanceR und StatementR and scales better for more parameters to come.
…selecting date span This makes the date span visible and editable in the search field and leaves the period parameter for further subdivision into smaller intervals. ReportPage.headingParams: avoid duplicate definition of headinglink in BalanceR and StatementR
Contributor
|
Your I think we have a similar idea (screenshots in https://groups.google.com/g/hledger/c/gnY4EQOR5Dc). My current prototype uses the parameter pattern you describe and Re |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to leave the period parameter for multi-period intervals and use date query for choosing the overall time range.
I am in the midst of adding more report options but need to perform some refactoring first.