Repository navigation
Conversation
With --base-url, a report's register links now carry a value parameter naming the report's valuation, mirroring --value's WHEN[,COMM] syntax: value=cost for -B, value=end for -V, value=end,COMM for -X COMM, and then, now, or a date for the other valuations. A register converting amounts the same way ends on the figure that was clicked. Consumers that do not know it ignore it. Cost combined with a valuation emits none, and such links open the register unconverted, as before. AI usage: Claude (Opus 5.5 and Fable 5), ~3k output tokens.
In tree mode, each html account cell's class is now "account depth-N", N being the row's depth in the displayed tree, so that a stylesheet can indent the tree and a UI can fold it. List modeis unchanged. AI usage: Claude (Opus 5.5 and Fable 5), ~2k output tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small additions hledger's HTML output
Part of a prototype I am working on (https://github.com/acinader/hledger/tree/web-playground, cf #2768)
they live in the hledger package and are useful on their own:
--base-url, register links carry avalueparameter naming thereport's valuation, mirroring
--value'sWHEN[,COMM]syntax(
value=cost,end,end,€,then,now, a date). A register thatconverts amounts the same way ends on the figure that was clicked —
hledger-web's register will use this; anything else ignores
it. Cost combined with a valuation emits none, as before.
(
account depth-N), so a stylesheet can indent the tree and a UI canfold it. List mode and other formats are unchanged.
Both are inert until a consumer uses them; the consumer is the
web-playground branch above, and #2768's refactoring.
Test plan:
Functional tests:
hledger/test/balance/base-url.testgains cases 23–24,and a new
hledger/test/balance/html.testpins the depth classes bothways.
AI usage: Claude (Opus 5.5 and Fable 5), ~5k output tokens.