Release: wait for the node to exit before stripping - #8
Merged
Conversation
The ARM64 job failed with 'strip: unable to copy file; reason: Text file busy'. 'bitcoin-cli stop' returns when the RPC is accepted, not when the process has gone, so strip raced a still-running bitcoind. The race was always there — x86_64 and macOS simply won it, and before this release the strip failure was swallowed by '2>/dev/null || true' so nobody would have noticed either way. Now that strip is load-bearing, wait for the process to actually exit and fail loudly if it never does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ARM64 release job failed with
strip: unable to copy file 'build/bin/bitcoind'; reason: Text file busy.bitcoin-cli stopreturns when the RPC call is accepted, not when the process has exited, so the Strip step raced a still-running bitcoind.The race was always there — x86_64 and macOS just won it. And before this release the strip failure was swallowed by
2>/dev/null || true, so it would have shipped a 291MB binary silently either way. Now that strip is load-bearing and gated on size, this waits for the process to actually exit and fails loudly if it never does.For the record, the size fix itself worked: x86_64 went from 291 MB to 13 MiB.