Skip to content

Release: wait for the node to exit before stripping #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotpixelgroup merged 1 commit into from
Jul 27, 2026
Merged

Release: wait for the node to exit before stripping #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,17 @@ jobs:
./build/bin/bitcoin-cli -datadir="$DD" -chain=regtest generatetoaddress 101 "$A" >/dev/null
test "$(./build/bin/bitcoin-cli -datadir="$DD" -chain=regtest getblockcount)" = "101"
./build/bin/bitcoin-cli -datadir="$DD" -chain=regtest stop
# `stop` returns as soon as the RPC is accepted, not when the process
# is gone — and strip cannot modify a running binary ("Text file
# busy"). Wait for it to actually exit.
for i in $(seq 1 60); do
pgrep -f "bitcoind -datadir=$DD" >/dev/null 2>&1 || break
sleep 1
done
if pgrep -f "bitcoind -datadir=$DD" >/dev/null 2>&1; then
echo "::error::bitcoind did not exit after stop"
exit 1
fi

# Strip, and prove it worked. The previous version swallowed every error
# into "2>/dev/null || true" and shipped a 292MB binary — 276MB of it
Expand Down
Loading