Link: require an explicit relay instead of a local-backend default - #269
Merged
Merged
Conversation
A first `xcb link` with no --relay and no XCB_RELAY_URL silently targeted http://127.0.0.1:3210, the local development backend. On a fresh machine the owner's email went to whatever answered there, and the request stalled until the 30-second client timeout reported only "relay request timed out". - No relay configured now stops before any network call with a message naming --relay and XCB_RELAY_URL. - `xcb link` and `xcb link --reauth` print the relay they ask for a code. - Relay timeouts name the deployment that did not answer. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0thernet
enabled auto-merge (squash)
September 28, 2026 18:20
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // replace/delete the auth session the worker is still using during OTP. | ||
| let mut client = RelayClient::connect(intent.endpoint()).await?; | ||
| if options.code.is_none() { | ||
| eprintln!("Requesting a sign-in code from {}.", intent.endpoint()); |
Closed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On the second launch-acceptance host, a plain
xcb linkstalled after the email prompt and then failed withrelay request timed out. Without--relayorXCB_RELAY_URL, a first link usedDEFAULT_DEPLOYMENT_URL = http://127.0.0.1:3210, the local development backend, not the owner's relay. Against the production relay, the same sign-in request round-trips in about 1s from the controller Mac (measured with a non-enrolled address, which the relay rejects silently without a counted attempt).Changes
deployment_urlhas no fallback: flag →XCB_RELAY_URL→ saved link, otherwiseNo relay configured; pass xcb link --relay … or set XCB_RELAY_URL, returned before any network call.xcb linkandxcb link --reauthprintRequesting a sign-in code from <relay>.RelayClienttimeouts name the deployment:relay request timed out: <url> did not answer within 30s.remote-operations.md,--relayhelp) and a CHANGELOG Unreleased entry.a_first_link_without_a_relay_refuses_instead_of_guessing_a_local_backend.Gates
cargo fmt --check,cargo clippy --workspace --all-targets --locked -D warnings, andcargo test --workspace --lockedpass locally (33 test binaries).🤖 Generated with Claude Code